Hi Catalin,

quoted

--- /dev/null
+++ b/drivers/net/smsc911x.h

[...]

quoted

+/* platform_device configuration data, should be assigned to
+ * the platform_device's dev.platform_data */
+struct smsc911x_platform_config {
+   unsigned int irq_polarity;
+   unsigned int irq_type;
+};

BTW, how could this structure be used in the platform specific code
(arch/arm/mach-*/* in my case)? This header file cannot be included
since it is not under the include/ directory and redefining the
structure for each platform is prone to errors (and too much
duplication). I can see other drivers place a header file (maybe only
containing the structure definition) in include/linux/ or include/asm-*/
(the latter if it is specific to only one architecture which I don't
think it is the case here). 

Thanks Catalin, I meant to ask if this the right thing to do.

I'll keep the device register definitions in the same place and move
struct smsc911x_platform_config to a new file in include/linux/.

Regards,
--
Steve Glendinning
SMSC GmbH
m: +44 777 933 9124
e: steve.glendinning@smsc.com