Re: [Uclinux-dist-devel] [PATCH] SMSC LAN911x and LAN921x vendor driver
From: Mike Frysinger <hidden>
Date: 2008-05-19 15:27:51
On Mon, May 19, 2008 at 8:34 AM, Steve Glendinning [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+++ b/drivers/net/smsc911x.c + * History: + * 05/05/2005 bahadir.balban@arm.com + * - Transition to linux coding style + * - Platform driver and module interface
i thought we were against this sort of changelog stuff in files. let the scm take care of the changelog.
+static int smsc911x_init(struct net_device *dev) +static int smsc911x_drv_probe(struct platform_device *pdev)
missing __devinit
+static int smsc911x_drv_remove(struct platform_device *pdev)
missing __devexit
+static struct platform_driver smsc911x_driver = {
+ .probe = smsc911x_drv_probe,
+ .remove = smsc911x_drv_remove,
+ .driver = {
+ .name = SMSC_CHIPNAME,
+ },
+};no suspend/resume ? :/ -mike