Thread (15 messages) 15 messages, 6 authors, 2008-06-04

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

From: Bill Gatliff <hidden>
Date: 2008-06-02 16:38:55

Possibly related (same subject, not in this thread)

Ben Hutchings wrote:
quoted
+static int smsc911x_phy_loopbacktest(struct smsc911x_data *pdata)
+{
+	int result = 0;
+	unsigned int i;
+	unsigned int val;
+	unsigned long flags;
+
+	/* Initialise tx packet using broadcast destination address */
+	for (i = 0; i < 6; i++)
+		pdata->loopback_tx_pkt[i] = (char)0xFF;
The cast to char is just noise.
Not sure.  What about signed vs. unsigned?


b.g.
-- 
Bill Gatliff
bgat@billgatliff.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help