Re: [Uclinux-dist-devel] [PATCH] SMSC LAN911x and LAN921x vendor driver
From: Mike Frysinger <hidden>
Date: 2008-05-19 15:50:38
From: Mike Frysinger <hidden>
Date: 2008-05-19 15:50:38
On Mon, May 19, 2008 at 11:45 AM, Catalin Marinas wrote:
On Mon, 2008-05-19 at 11:27 -0400, Mike Frysinger wrote:quoted
On Mon, May 19, 2008 at 8:34 AM, Steve Glendinning [off-list ref] wrote:quoted
+++ b/drivers/net/smsc911x.c + * History: + * 05/05/2005 bahadir.balban@arm.com + * - Transition to linux coding style + * - Platform driver and module interfacei thought we were against this sort of changelog stuff in files. let the scm take care of the changelog.I don't have a strong opinion on whether the changelog in the file should be kept or not and I won't argue. However, in this particular instance there is no SCM log since the driver is not merged into the mainline kernel. When/if it is merged, this will happen as a patch without an SCM log.
while all true, the problem is that people who make updates in the future often times will also update the in-file changelog you could move the changelog out of the file and into the first commit message -mike