On Mon, 2008-05-19 at 13:34 +0100, Steve Glendinning wrote:

Attached is a driver for SMSC's LAN911x and LAN921x families of embedded
ethernet controllers.

[...]

 drivers/net/Kconfig    |   13 +
 drivers/net/Makefile   |    1 +
 drivers/net/smsc911x.c | 2285 ++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/net/smsc911x.h |  389 ++++++++

Maybe you should patch the MAINTAINERS file as well since it's not clear
from the file header who is maintaining it.

[...]

+/* platform_device configuration data, should be assigned to
+ * the platform_device's dev.platform_data */
+struct smsc911x_platform_config {
+	unsigned int irq_polarity;
+	unsigned int irq_type;
+};

BTW, how could this structure be used in the platform specific code
(arch/arm/mach-*/* in my case)? This header file cannot be included
since it is not under the include/ directory and redefining the
structure for each platform is prone to errors (and too much
duplication). I can see other drivers place a header file (maybe only
containing the structure definition) in include/linux/ or include/asm-*/
(the latter if it is specific to only one architecture which I don't
think it is the case here). 

-- 
Catalin