Thread (181 messages) 181 messages, 8 authors, 2009-11-28

Re: [RFC PATCH 12/19] powerpc: gamecube: platform support

From: Albert Herranz <hidden>
Date: 2009-11-25 17:24:09

Segher Boessenkool wrote:
quoted
+static struct of_device_id gamecube_of_bus[] = {
+    { .compatible = "nintendo,flipper", },
+    { },
+};
+
+static int __init gamecube_device_probe(void)
+{
+    if (!machine_is(gamecube))
+        return 0;
+
+    of_platform_bus_probe(NULL, gamecube_of_bus, NULL);
+    return 0;
+}
You really do not need a platform bus as far as I can see?
We need it as it currently doesn't match with the default bus ids.

const struct of_device_id of_default_bus_ids[] = {
        { .type = "soc", },
        { .compatible = "soc", },
        { .type = "plb5", },
        { .type = "plb4", },
        { .type = "opb", },
        { .type = "simple", },
        {},
};

Should I introduce a .type property matching any of those above in the soc node, and get rid of the explicit bus probe?

Thanks,
Albert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help