Thread (55 messages) 55 messages, 7 authors, 2007-10-02

Re: [PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze)

From: Grant Likely <hidden>
Date: 2007-09-28 20:53:11

On 9/28/07, Grant Likely [off-list ref] wrote:
On 9/28/07, Olof Johansson [off-list ref] wrote:
quoted
On Fri, Sep 28, 2007 at 02:42:32PM -0600, Grant Likely wrote:
quoted
On 9/28/07, Olof Johansson [off-list ref] wrote:
quoted
Also, I'm not sure you need to cast port->membase to void*, do you? The
math will still be right since it's declared as char *.
membase is now defined as u32*, so the cast is needed.
Hm, I must have looked at a stale tree.
No, wait.  You're right.  It is a char*.  I'll drop the cast.
Wait, I'm wrong again... it's in/out_be32 that expects an (unsigned*).
 The compiler complains without the cast.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help