Thread (55 messages) 55 messages, 7 authors, 2007-10-02

Re: [PATCH 01/18] Virtex: Add uartlite bootwrapper driver

From: Josh Boyer <hidden>
Date: 2007-09-28 20:27:08

On Fri, 28 Sep 2007 14:04:04 -0600
"Grant Likely" [off-list ref] wrote:
On 9/28/07, Arnd Bergmann [off-list ref] wrote:
quoted
On Friday 28 September 2007, Grant Likely wrote:
quoted
+static void uartlite_putc(unsigned char c)
+{
+while ((in_be32(reg_base + 0x8) & 0x08) != 0); /* spin */
+out_be32(reg_base + 0x4, c);
+}
When coding a spin-loop, it's better to do a cpu_relax() between
each attempt.
Is cpu_relax even implemented in the bootwrapper?
No.  And it doesn't need to be :)

josh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help