Re: [PATCH 02/18] Add Kconfig macros for Xilinx Virtex support

On 9/28/07, Olof Johansson [off-list ref] wrote:

On Fri, Sep 28, 2007 at 12:16:01PM -0600, Grant Likely wrote:

quoted

From: Grant Likely <redacted>

Signed-off-by: Grant Likely <redacted>
---

 arch/powerpc/platforms/40x/Kconfig |   30 +++++++++++++++++-------------
 1 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/arch/powerpc/platforms/40x/Kconfig b/arch/powerpc/platforms/40x/Kconfig
index c3dce3b..1aae0e6 100644
--- a/arch/powerpc/platforms/40x/Kconfig
+++ b/arch/powerpc/platforms/40x/Kconfig

@@ -61,13 +61,14 @@ config WALNUT
      help
        This option enables support for the IBM PPC405GP evaluation board.

-#config XILINX_ML300
-#    bool "Xilinx-ML300"
-#    depends on 40x
-#    default y
-#    select VIRTEX_II_PRO
-#    help
-#      This option enables support for the Xilinx ML300 evaluation board.
+config XILINX_VIRTEX_GENERIC_BOARD
+     bool "Generic Xilinx Virtex board"
+     depends on 40x
+     default y
+     select VIRTEX_II_PRO
+     select VIRTEX_4_FX
+     help
+       This option enables generic support for Xilinx Virtex based boards.

I would appreciate a bit verboser help text here, i.e. including what
boards are considered generic. Maybe something like "...including ML403,
<x>, <y>, and other 4FX/IIPro-based boards"?

Done.

          This option enables generic support for Xilinx Virtex based boards.

+         The generic virtex board support matches any device tree which
+         specifies 'xilinx,virtex' in its compatible field.  This includes
+         the Xilinx ML3xx and ML4xx reference designs using the powerpc
+         core.
+
+         Most Virtex designs should use this unless it needs to do some
+         special configuration at board probe time.
+

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195