Thread (55 messages) flat view 55 messages, 7 authors, 2007-10-02

Re: [PATCH 12/18] Uartlite: Let the console be initialized earlier

From: Grant Likely <hidden>
Date: 2007-09-28 20:01:25

On 9/28/07, Arnd Bergmann [off-list ref] wrote:
On Friday 28 September 2007, Grant Likely wrote:
quoted
+#else /* CONFIG_OF */
+static void __init ulite_console_of_find_device(int id) { /* do nothing */ }
+#endif /* CONFIG_OF */
Shouldn't this be inline? It shouldn't matter much since most of the time
gcc -funit-at-a-time takes care of this, but it's common to make the inlining
explicit.
heh, I even had the inline in there on an earlier version of the
patch.  I can add it back it.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help