Re: [PATCH 27/61] cpm2: Fix whitespace in cpm2_clk_setup().
From: Arnd Bergmann <arnd@arndb.de>
Date: 2007-07-19 00:21:33
On Wednesday 18 July 2007, Scott Wood wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Scott Wood <redacted> --- =A0arch/powerpc/sysdev/cpm2_common.c | =A0 =A02 +- =A01 files changed, 1 insertions(+), 1 deletions(-) =20diff --git a/arch/powerpc/sysdev/cpm2_common.c b/arch/powerpc/sysdev/cpm2=
_common.c
quoted hunk ↗ jump to hunk
index 4e840bd..7e3a983 100644--- a/arch/powerpc/sysdev/cpm2_common.c +++ b/arch/powerpc/sysdev/cpm2_common.c@@ -233,7 +233,7 @@ int cpm2_clk_setup(enum cpm_clk_target target, int cl=
ock, int mode)
=A0=A0=A0=A0=A0=A0=A0=A0}
=A0
=A0=A0=A0=A0=A0=A0=A0=A0if (mode =3D=3D CPM_CLK_RX)
-=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0shift +=3D3;
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0shift +=3D 3;
=A0
=A0=A0=A0=A0=A0=A0=A0=A0for (i =3D 0; i < ARRAY_SIZE(clk_map); i++) {
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (clk_map[i][0] =3D=3D =target && clk_map[i][1] =3D=3D clock) {
While all your 61 patches look really good to me in general, I think you're=
driving
the 'one patch per logical change' mantra a little too far. E.g. a number o=
f them
could simply have been consolidated under 'fix obvious coding style violati=
ons in
arch/powerpc'.
Having patches that fix a single whitespace bug only causes extra work for =
both
the author and the reviewer without much benefit.
Arnd <><