Re: [PATCH 51/61] cpm_uart: Be an of_platform device when using arch/powerpc.

On Wednesday 18 July 2007, Scott Wood wrote:

+
+static struct of_device_id cpm_uart_match[] =3D {
+=A0=A0=A0=A0=A0=A0=A0{
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0.compatible =3D "fsl,cpm-ua=

rt",

+=A0=A0=A0=A0=A0=A0=A0},
+=A0=A0=A0=A0=A0=A0=A0{}
=A0};
+

I guess it's fine as it is, but it might be nicer if you change
this to have separate entries for scc and smc, and then pass
different values though of_device_id->data into the probe()
function.

Not sure if it makes much difference at all, but that's what
I did in the of_serial driver.

	Arnd <><