Re: [PATCH 11/40] autonuma: define the autonuma flags
From: Konrad Rzeszutek Wilk <hidden>
Date: 2012-06-30 04:58:32
Also in:
lkml
On Thu, Jun 28, 2012 at 02:55:51PM +0200, Andrea Arcangeli wrote:
quoted hunk ↗ jump to hunk
These flags are the ones tweaked through sysfs, they control the behavior of autonuma, from enabling disabling it, to selecting various runtime options. Signed-off-by: Andrea Arcangeli <redacted> --- include/linux/autonuma_flags.h | 62 ++++++++++++++++++++++++++++++++++++++++ 1 files changed, 62 insertions(+), 0 deletions(-) create mode 100644 include/linux/autonuma_flags.hdiff --git a/include/linux/autonuma_flags.h b/include/linux/autonuma_flags.h new file mode 100644 index 0000000..5e29a75 --- /dev/null +++ b/include/linux/autonuma_flags.h@@ -0,0 +1,62 @@ +#ifndef _LINUX_AUTONUMA_FLAGS_H +#define _LINUX_AUTONUMA_FLAGS_H + +enum autonuma_flag {
These aren't really flags. They are bit-fields. A
+ AUTONUMA_FLAG,
Looking at the code, this is to turn it on. Perhaps a better name such as: AUTONUMA_ACTIVE_FLAG ?
+ AUTONUMA_IMPOSSIBLE_FLAG, + AUTONUMA_DEBUG_FLAG, + AUTONUMA_SCHED_LOAD_BALANCE_STRICT_FLAG,
I might have gotten my math wrong, but if you have AUTONUMA_SCHED_LOAD_BALACE.. set (so 3), that also means that bit 0 and 1 are on. In other words AUTONUMA_FLAG and AUTONUMA_IMPOSSIBLE_FLAG are turned on.
+ AUTONUMA_SCHED_CLONE_RESET_FLAG, + AUTONUMA_SCHED_FORK_RESET_FLAG, + AUTONUMA_SCAN_PMD_FLAG,
So this is 6, which means 110 bits. So AUTONUMA_FLAG gets turned off. You definitly want to convert these to #defines or at least define the proper numbers.
+ AUTONUMA_SCAN_USE_WORKING_SET_FLAG,
+ AUTONUMA_MIGRATE_DEFER_FLAG,
+};
+
+extern unsigned long autonuma_flags;
+
+static inline bool autonuma_enabled(void)
+{
+ return !!test_bit(AUTONUMA_FLAG, &autonuma_flags);
+}
+
+static inline bool autonuma_debug(void)
+{
+ return !!test_bit(AUTONUMA_DEBUG_FLAG, &autonuma_flags);
+}
+
+static inline bool autonuma_sched_load_balance_strict(void)
+{
+ return !!test_bit(AUTONUMA_SCHED_LOAD_BALANCE_STRICT_FLAG,
+ &autonuma_flags);
+}
+
+static inline bool autonuma_sched_clone_reset(void)
+{
+ return !!test_bit(AUTONUMA_SCHED_CLONE_RESET_FLAG,
+ &autonuma_flags);
+}
+
+static inline bool autonuma_sched_fork_reset(void)
+{
+ return !!test_bit(AUTONUMA_SCHED_FORK_RESET_FLAG,
+ &autonuma_flags);
+}
+
+static inline bool autonuma_scan_pmd(void)
+{
+ return !!test_bit(AUTONUMA_SCAN_PMD_FLAG, &autonuma_flags);
+}
+
+static inline bool autonuma_scan_use_working_set(void)
+{
+ return !!test_bit(AUTONUMA_SCAN_USE_WORKING_SET_FLAG,
+ &autonuma_flags);
+}
+
+static inline bool autonuma_migrate_defer(void)
+{
+ return !!test_bit(AUTONUMA_MIGRATE_DEFER_FLAG, &autonuma_flags);
+}
+
+#endif /* _LINUX_AUTONUMA_FLAGS_H */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>