Re: [PATCH v2 08/13] HID: playstation: add DualSense classic rumble support.

2021. január 7., csütörtök 21:41 keltezéssel, Barnabás Pőcze írta:

[...]

quoted

+struct dualsense_output_report {
+	uint8_t *data; /* Start of data */
+	uint8_t len; /* Size of output report */
+
+	/* Points to Bluetooth data payload in case for a Bluetooth report else NULL. */
+	struct dualsense_output_report_bt *bt;
+	/* Points to USB data payload in case for a USB report else NULL. */
+	struct dualsense_output_report_usb *usb;
+	/* Points to common section of report, so past any headers */
+	struct dualsense_output_report_common *common;
+};
[...]
+static void dualsense_init_output_report(struct dualsense *ds, struct dualsense_output_report *rp,
+		void *buf)

If the dualsense struct is already passed in, couldn't this function use
`ds->output_report_dmabuf` directly?
[...]

Never mind, sorry, the next patch answered this question.