Re: [PATCH v2 01/13] HID: playstation: initial DualSense USB support.
From: Jiri Kosina <jikos@kernel.org>
Date: 2021-01-04 12:21:23
On Sat, 2 Jan 2021, Roderick Colenbrander wrote:
quoted hunk ↗ jump to hunk
From: Roderick Colenbrander <roderick.colenbrander@sony.com> Implement support for PlayStation DualSense gamepad in USB mode. Support features include buttons and sticks, which adhere to the Linux gamepad spec. Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com> --- MAINTAINERS | 6 + drivers/hid/Kconfig | 9 + drivers/hid/Makefile | 1 + drivers/hid/hid-ids.h | 1 + drivers/hid/hid-playstation.c | 321 ++++++++++++++++++++++++++++++++++ drivers/hid/hid-quirks.c | 3 + 6 files changed, 341 insertions(+) create mode 100644 drivers/hid/hid-playstation.cdiff --git a/MAINTAINERS b/MAINTAINERS index f81d598a8556..0ecae30af074 100644 --- a/MAINTAINERS +++ b/MAINTAINERS@@ -7918,6 +7918,12 @@ F: drivers/hid/ F: include/linux/hid* F: include/uapi/linux/hid* +HID PLAYSTATION DRIVER +M: Roderick Colenbrander <roderick.colenbrander@sony.com> +L: linux-input@vger.kernel.org +S: Supported +F: drivers/hid/hid-playstation.c + HID SENSOR HUB DRIVERS M: Jiri Kosina <jikos@kernel.org> M: Jonathan Cameron <jic23@kernel.org>diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 7bdda1b5b221..d3258e806998 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig@@ -853,6 +853,15 @@ config HID_PLANTRONICS Say M here if you may ever plug in a Plantronics USB audio device. +config HID_PLAYSTATION + tristate "PlayStation HID Driver" + default !EXPERT
Minor nit: these '!EXPERT' defaults are there only for drivers that were created during the big "let's separate all the quirks from hid-core into individual driver" bang that happened ages ago. For new drivers, we follow what's common in other driver subsystems, and don't force the default. No need to resend if it'd be just for this change, I can adjust it when applying. Thanks, -- Jiri Kosina SUSE Labs