Hi Barnabás,

On Wed, Dec 30, 2020 at 4:08 PM Barnabás Pőcze [off-list ref] wrote:

Hi


2020. december 19., szombat 7:23 keltezéssel, Roderick Colenbrander írta:

quoted

[...]
+static const struct hid_device_id ps_devices[] = {
+     { HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS5_CONTROLLER),
+             .driver_data = 0 },
+};
[...]

I have come across an AUR package [1], and looking at the modifications applied
there (work-without-modifying-hid-quirks.patch), I think should be a terminating
entry in this array. And maybe `MODULE_DEVICE_TABLE()` is also missing?

[1]: https://aur.archlinux.org/packages/hid-playstation-dkms/


Regards,
Barnabás Pőcze

Good catch, that's indeed missing. I wonder how I didn't stumble on
that (I used an unmodified kernel here and loaded it out of tree). In
any case I will add it and use it in revision 2.

Regards,
Roderick