Thread (43 messages) 43 messages, 6 authors, 2020-12-31

Re: [PATCH 11/13] HID: playstation: add DualSense player LEDs support.

From: Barnabás Pőcze <hidden>
Date: 2020-12-29 18:50:52

2020. december 28., hétfő 23:02 keltezéssel, Roderick Colenbrander írta:
[...]
quoted
Furthermore, I don't quite see the purpose of this function. The LED core
can handle if no brightness_get() callback is provided. And since this
function returns just a cached value, I fail to see how it is different from
the default behaviour of the LED core, which is returning the last brightness
value. Am I missing something?
Not all values may get set through sysfs. For example in the next
patch (12/13) the driver sets a default player LED mask value directly
and may set e.g. 0x1f or so. This could use the LED APIs, but the LED
framework doesn't have any group LED support (besides the new
multicolor class) and as such would get scheduled across multiple
output reports.
[...]
You're right, I've missed that.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help