Re: [PATCH 12/13] HID: playstation: DualSense set LEDs to default player id.

On Sat, Dec 26, 2020 at 4:08 PM Samuel Čavoj [off-list ref] wrote:

Hi Roderick,

this one is very much just a nitpick, yet not completely pointless.

On 18.12.2020 22:23, Roderick Colenbrander wrote:

quoted

@@ -837,8 +859,8 @@ static void dualsense_output_worker(struct work_struct *work)
      }

      if (ds->update_player_leds) {
-             r->valid_flag1 |= DS_OUTPUT_VALID_FLAG1_PLAYER_INDICATOR_CONTROL_ENABLE;
-             r->player_leds = ds->player_leds_state;
+             common->valid_flag1 |= DS_OUTPUT_VALID_FLAG1_PLAYER_INDICATOR_CONTROL_ENABLE;
+             common->player_leds = ds->player_leds_state;

This change should be merged into the previous patch, as it doesn't
compile without it (typo, I suppose). Could lead to annoyment during
git bisect and all that.

Yep that doesn't belong here. Rebase artifact and I didn't compile
that particular patch after the fact apparently... Will run a 'rebase
-x' with a compile script on the next revision to make sure nothing
got messed up...

Thanks,
Roderick