Re: [PATCH v4 04/14] GPIO: Add gpio-ingenic driver
From: Linus Walleij <hidden>
Date: 2017-04-07 09:34:48
Also in:
linux-devicetree, linux-gpio, linux-mips, linux-mmc, linux-pwm, lkml
On Sun, Apr 2, 2017 at 10:42 PM, Paul Cercueil [off-list ref] wrote:
This driver handles the GPIOs of all the Ingenic JZ47xx SoCs currently supported by the upsteam Linux kernel. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
I guess you saw the Kconfig complaint from the build robot, please fix that so we get silent builds.
v2: Consider it's a new patch. Completely rewritten from v1. v3: Add missing include <linux/pinctrl/consumer.h> and drop semicolon after } v4: Completely rewritten from v3.
I really like v4 :)
+static inline bool gpio_get_value(struct ingenic_gpio_chip *jzgc, u8 offset)
Actually the return value should be an int. I know, it is a historical artifact, if we change it we need to change it everywhere.
quoted hunk ↗ jump to hunk
+ /* DO NOT EXPAND THIS: FOR BACKWARD GPIO NUMBERSPACE COMPATIBIBILITY + * ONLY: WORK TO TRANSITION CONSUMERS TO USE THE GPIO DESCRIPTOR API IN + * <linux/gpio/consumer.h> INSTEAD. + */ + jzgc->gc.base = cell->id * 32;
OK then :) This is merge material. Yours, Linus Walleij