Re: [PATCH 13/13] MIPS: jz4740: Remove custom GPIO code

From
Paul Cercueil <paul@crapouillou.net>
Date
2017-01-20 10:01:43
Also in
linux-devicetree, linux-gpio, linux-mips, linux-mmc, linux-pwm, lkml
Reply to
Linus Walleij, 2017-01-19
Le 2017-01-19 10:07, Linus Walleij a écrit :
On Wed, Jan 18, 2017 at 12:14 AM, Paul Cercueil [off-list ref] 
wrote:
quoted
All the drivers for the various hardware elements of the jz4740 SoC 
have been modified to use the pinctrl framework for their pin 
configuration needs. As such, this platform code is now unused and can 
be deleted. Signed-off-by: Paul Cercueil [off-list ref]
I feel I might have come across as a bit harsh in the previous review 
of the
patches leading up to this one. In that case I'm sorry.

I can clearly see that the intent of the series is to remove this 
hopelessly
idiomatic code from the MIPS hurdle, and move these systems over
to standard frameworks.

In a way, if I look at the kernel as a whole, it would likely look 
better
after these patches were merged, than before. Even with the
shortcomings I painted out in the previous review comments.

A very complicated piece of messy code is cut from MIPS.

I think this is very valuable work and well worth persuing, so please
go ahead and work with the series, your effort is very much 
appreciated!

Yours,
Linus Walleij
Well thank you for your very constructive criticism ;) And for your 
review.
I'll submit a v2 very soon - I don't want to miss the 4.11 merge.

Regards,
-Paul
Thread (142 messages) 142 messages, 11 authors, 2017-07-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help