Thread (142 messages) 142 messages, 11 authors, 2017-07-31

Re: [PATCH 09/13] mmc: jz4740: Let the pinctrl driver configure the pins

From: Ulf Hansson <hidden>
Date: 2017-01-19 10:55:50
Also in: linux-devicetree, linux-gpio, linux-mips, linux-mmc, linux-pwm, lkml

[...]
-#ifdef CONFIG_PM_SLEEP
-
-static int jz4740_mmc_suspend(struct device *dev)
-{
-       struct jz4740_mmc_host *host = dev_get_drvdata(dev);
-
-       jz_gpio_bulk_suspend(jz4740_mmc_pins, jz4740_mmc_num_pins(host));
-
Shouldn't this be replaced with a call to:
pinctrl_pm_select_sleep_state();
-       return 0;
-}
-
-static int jz4740_mmc_resume(struct device *dev)
-{
-       struct jz4740_mmc_host *host = dev_get_drvdata(dev);
-
-       jz_gpio_bulk_resume(jz4740_mmc_pins, jz4740_mmc_num_pins(host));
Shouldn't this be replaced with a call to:
pinctrl_pm_select_default_state();

[...]

Kind regards
Uffe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help