Re: Re: [PATCH] fbdev: Fix IO access in rivafb

On Sun, Nov 14, 2004 at 05:29:46AM +0800, Antonino A. Daplas wrote:

On Sunday 14 November 2004 02:00, Linus Torvalds wrote:

quoted

On Sat, 13 Nov 2004, Antonino A. Daplas wrote:

quoted

Why not use in_be* and out_be* for __raw_read and raw_write?

Please don't start using some stupid magic ppc-specific macros for a
driver that has no reason to be PPC-specific. It then only causes bugs
that show on one platform and not another.

I'm not. I'm just wondering that if the other approach was taken (keep the
hardware in little endian mode), then the write/read* macros, which are just
wrappers for in_le*/out_le*, would have been used. Would it help fix (or
cover up) bugs that are in PPC but not x86? 

XFree86 switches the card to big endian mode anyway. Running rivafb in
little endian might cause us great deals of pain for little gain.
Cheers,
 -- Guido


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8