Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb
From: Antonino A. Daplas <hidden>
Date: 2004-11-08 20:03:12
Also in:
lkml
On Monday 08 November 2004 23:21, Linus Torvalds wrote:
On Mon, 8 Nov 2004, Antonino A. Daplas wrote:quoted
How about this patch? This is almost the original macro in riva_hw.h, with the __force annotation.Why not just use __raw_readl/__raw_writel?
Ok. Tony In big endian machines, the read*/write* accessors do a byteswap for an inherently little endian PCI bus. However, rivafb puts the hardwire in big endian register access, thus the byteswap is not needed. So, instead of read*/write*, use __raw_read*/__raw_write*. Signed-off-by: Antonino Daplas <redacted> --- diff -Nru a/drivers/video/riva/riva_hw.h b/drivers/video/riva/riva_hw.h
--- a/drivers/video/riva/riva_hw.h 2004-11-09 03:45:55 +08:00
+++ b/drivers/video/riva/riva_hw.h 2004-11-09 03:50:32 +08:00@@ -77,14 +77,18 @@ #include <asm/io.h> #define NV_WR08(p,i,d) out_8(p+i, d) #define NV_RD08(p,i) in_8(p+i) +#define NV_WR16(p,i,d) (__raw_writew((d), (u16 __iomem *)(p) + (i)/2)) +#define NV_RD16(p,i) (__raw_readw((u16 __iomem *)(p) + (i)/2)) +#define NV_WR32(p,i,d) (__raw_writel((d), (u32 __iomem *)(p) + (i)/4)) +#define NV_RD32(p,i) (__raw_readl((u32 __iomem *)(p) + (i)/4)) #else #define NV_WR08(p,i,d) (writeb((d), (u8 __iomem *)(p) + (i))) #define NV_RD08(p,i) (readb((u8 __iomem *)(p) + (i))) -#endif #define NV_WR16(p,i,d) (writew((d), (u16 __iomem *)(p) + (i)/2)) #define NV_RD16(p,i) (readw((u16 __iomem *)(p) + (i)/2)) #define NV_WR32(p,i,d) (writel((d), (u32 __iomem *)(p) + (i)/4)) #define NV_RD32(p,i) (readl((u32 __iomem *)(p) + (i)/4)) +#endif #define VGA_WR08(p,i,d) NV_WR08(p,i,d) #define VGA_RD08(p,i) NV_RD08(p,i)