Re: Re: [PATCH] fbdev: Fix IO access in rivafb
From: Linus Torvalds <torvalds@osdl.org>
Date: 2004-11-08 19:29:27
Also in:
lkml
On Mon, 8 Nov 2004, Antonino A. Daplas wrote:
How about this patch? This is almost the original macro in riva_hw.h, with the __force annotation.
Why not just use __raw_readl/__raw_writel? That's what they exist for, and they still do any IO accesses correctly, which a direct store does not do (it would seriously break on older alphas, for example). Of course, clearly the thing has never worked on things like alphas anyway, but the point is that accessing IO memory with direct loads and stores really _is_ fundamentally wrong, even if it happens to work on many architectures. The keyword is "happens". Linus ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click