Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb

From
Linus Torvalds <torvalds@osdl.org>
Date
2004-11-08 20:13:33
Also in
lkml
Reply to
Antonino A. Daplas, 2004-11-08

On Tue, 9 Nov 2004, Antonino A. Daplas wrote:
In big endian machines, the read*/write* accessors do a byteswap for an
inherently little endian PCI bus.  However, rivafb puts the hardwire in big
endian register access, thus the byteswap is not needed. So, instead of
read*/write*, use __raw_read*/__raw_write*.
This fix should make the #ifdef CONFIG_PCC entirely superfluous afaik. 

The thing is, once riva does its HW accesses right, the special cases just 
go away. There's a reason we have abstractions.. 

Does anybody have the hardware to test with?

		Linus
Thread (29 messages) 29 messages, 7 authors, last reply 2004-11-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help