Thread (29 messages) 29 messages, 7 authors, 2004-11-13

Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2004-11-08 21:55:29
Also in: lkml

On Mon, 2004-11-08 at 17:06 +0800, Antonino A. Daplas wrote:
How about this patch?  This is almost the original macro in riva_hw.h,
with the __force annotation.
I don't like it neither. It lacks barriers. the rivafb driver
notoriously lacks barriers, except in a few places where it was so bad
that it actually broke all the time, where we added some. This
originates from the X "nv" driver written by Mark Vojkovich who didn't
want to hear about barriers for perfs reasons I think.

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help