Re: Re: [PATCH] fbdev: Fix IO access in rivafb
From: Guido Guenther <agx@sigxcpu.org>
Date: 2004-11-13 13:06:13
Also in:
lkml
On Sat, Nov 13, 2004 at 08:00:30PM +0800, Antonino A. Daplas wrote:
On Saturday 13 November 2004 19:22, Guido Guenther wrote:quoted
On Sat, Nov 13, 2004 at 12:39:32PM +1100, Benjamin Herrenschmidt wrote:quoted
On Fri, 2004-11-12 at 20:18 +0100, Guido Guenther wrote:In 2.6.10-rc1-mm5 {in,out}_8 and read/writeb are exactly identical, only __raw_{read,write}b is different. So you mean __raw_{read,write}b in the above? (no nitpicking, just want to be sure I understand this correctly).Why not use in_be* and out_be* for __raw_read and raw_write? If I understand correctly, they also have barriers. Or would that hurt performance?
I think it would. XFree86 comes along without these barriers nicely (and this this driver was written with documentation ;), so rivafb should be o.k. too. -- Guido ------------------------------------------------------- This SF.Net email is sponsored by: InterSystems CACHE FREE OODBMS DOWNLOAD - A multidimensional database that combines robust object and relational technologies, making it a perfect match for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8