[PATCH v6 13/16] PCI: rzg3s-host: Add support for RZ/G3E PCIe controller
From: John Madieu <john.madieu.xa@bp.renesas.com>
Date: 2026-02-19 22:37:18
Also in:
linux-clk, linux-pci, linux-renesas-soc
Subsystem:
pci native host bridge and endpoint drivers, pci subsystem, pcie driver for renesas rz/g3s series, the rest · Maintainers:
Lorenzo Pieralisi, Krzysztof Wilczyński, Manivannan Sadhasivam, Bjorn Helgaas, Claudiu Beznea, Linus Torvalds
Add support for the PCIe controller found in RZ/G3E SoCs to the existing
RZ/G3S PCIe host driver. The RZ/G3E PCIe controller is similar to the
RZ/G3S's, with the following key differences:
- Supports PCIe Gen3 (8.0 GT/s) link speeds alongside Gen2 (5.0 GT/s)
- Uses a different reset control mechanism via AXI registers instead
of the Linux reset framework
- Requires specific SYSC configuration for link state control and
Root Complex mode selection
Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
---
Changes:
v6:
- Use rzg3s_sysc_config_func() with per-function calls instead of
rzg3s_sysc_config() with -1 skip pattern, as suggested by Claudiu
- Extend enum rzg3s_sysc_func_id with L1_ALLOW and MODE entries
- Use regmap_update_bits() consistently for all SYSC accesses
- Shorten comment to "Put controller in RC mode and de-assert RST_RSM_B."
- Drop "Enable ASPM L1 transition" comment (function ID is self-documenting)
v5:
- Introduce rzg3s_sysc_config() helper for sys configuration
v4: No changes
v3: No changes
drivers/pci/controller/pcie-rzg3s-host.c | 98 ++++++++++++++++++++++++
1 file changed, 98 insertions(+)
diff --git a/drivers/pci/controller/pcie-rzg3s-host.c b/drivers/pci/controller/pcie-rzg3s-host.c
index 413978feba1a..021b01746157 100644
--- a/drivers/pci/controller/pcie-rzg3s-host.c
+++ b/drivers/pci/controller/pcie-rzg3s-host.c@@ -111,6 +111,16 @@ #define RZG3S_PCI_PERM_CFG_HWINIT_EN BIT(2) #define RZG3S_PCI_PERM_PIPE_PHY_REG_EN BIT(1) +/* RZ/G3E specific registers */ +#define RZG3E_PCI_RESET 0x310 +#define RZG3E_PCI_RESET_RST_OUT_B BIT(6) +#define RZG3E_PCI_RESET_RST_PS_B BIT(5) +#define RZG3E_PCI_RESET_RST_LOAD_B BIT(4) +#define RZG3E_PCI_RESET_RST_CFG_B BIT(3) +#define RZG3E_PCI_RESET_RST_RSM_B BIT(2) +#define RZG3E_PCI_RESET_RST_GP_B BIT(1) +#define RZG3E_PCI_RESET_RST_B BIT(0) + #define RZG3S_PCI_MSIRE(id) (0x600 + (id) * 0x10) #define RZG3S_PCI_MSIRE_ENA BIT(0)
@@ -184,10 +194,14 @@ struct rzg3s_sysc_function { /** * enum rzg3s_sysc_func_id - System controller function IDs * @RZG3S_SYSC_FUNC_ID_RST_RSM_B: RST_RSM_B SYSC function ID + * @RZG3S_SYSC_FUNC_ID_L1_ALLOW: L1 allow SYSC function ID + * @RZG3S_SYSC_FUNC_ID_MODE: Mode SYSC function ID * @RZG3S_SYSC_FUNC_ID_MAX: Max SYSC function ID */ enum rzg3s_sysc_func_id { RZG3S_SYSC_FUNC_ID_RST_RSM_B, + RZG3S_SYSC_FUNC_ID_L1_ALLOW, + RZG3S_SYSC_FUNC_ID_MODE, RZG3S_SYSC_FUNC_ID_MAX, };
@@ -1135,6 +1149,49 @@ static int rzg3s_config_deinit(struct rzg3s_pcie_host *host) host->cfg_resets); } +/* RZ/G3E SoC-specific config implementations */ +static void rzg3e_pcie_config_pre_init(struct rzg3s_pcie_host *host) +{ + /* + * De-assert LOAD_B and CFG_B during configuration phase. + * These are part of the RZ/G3E reset register, not reset framework. + * Other reset bits remain asserted until config_post_init. + */ + rzg3s_pcie_update_bits(host->axi, RZG3E_PCI_RESET, + RZG3E_PCI_RESET_RST_LOAD_B | RZG3E_PCI_RESET_RST_CFG_B, + RZG3E_PCI_RESET_RST_LOAD_B | RZG3E_PCI_RESET_RST_CFG_B); +} + +static int rzg3e_config_deinit(struct rzg3s_pcie_host *host) +{ + writel_relaxed(0, host->axi + RZG3E_PCI_RESET); + return 0; +} + +static int rzg3e_config_post_init(struct rzg3s_pcie_host *host) +{ + /* De-assert PS_B, GP_B, RST_B */ + rzg3s_pcie_update_bits(host->axi, RZG3E_PCI_RESET, + RZG3E_PCI_RESET_RST_PS_B | RZG3E_PCI_RESET_RST_GP_B | + RZG3E_PCI_RESET_RST_B, + RZG3E_PCI_RESET_RST_PS_B | RZG3E_PCI_RESET_RST_GP_B | + RZG3E_PCI_RESET_RST_B); + + /* + * According to the RZ/G3E HW manual (Rev.1.15, Table 6.6-130 + * Initialization Procedure (RC)), hardware requires >= 500us delay + * before final reset deassert. + */ + fsleep(500); + + /* De-assert OUT_B and RSM_B to complete reset sequence */ + rzg3s_pcie_update_bits(host->axi, RZG3E_PCI_RESET, + RZG3E_PCI_RESET_RST_OUT_B | RZG3E_PCI_RESET_RST_RSM_B, + RZG3E_PCI_RESET_RST_OUT_B | RZG3E_PCI_RESET_RST_RSM_B); + + return 0; +} + static void rzg3s_pcie_irq_init(struct rzg3s_pcie_host *host) { /*
@@ -1320,6 +1377,12 @@ static int rzg3s_pcie_host_init(struct rzg3s_pcie_host *host) if (ret) goto config_deinit; + /* Enable ASPM L1 transition for SoCs that use it */ + ret = rzg3s_sysc_config_func(host->sysc, + RZG3S_SYSC_FUNC_ID_L1_ALLOW, 1); + if (ret) + goto config_deinit; + /* Initialize the interrupts */ rzg3s_pcie_irq_init(host);
@@ -1667,6 +1730,11 @@ static int rzg3s_pcie_probe(struct platform_device *pdev) goto port_refclk_put; } + /* Put controller in RC mode and de-assert RST_RSM_B. */ + ret = rzg3s_sysc_config_func(sysc, RZG3S_SYSC_FUNC_ID_MODE, 1); + if (ret) + goto port_refclk_put; + ret = rzg3s_sysc_config_func(sysc, RZG3S_SYSC_FUNC_ID_RST_RSM_B, 1); if (ret) goto port_refclk_put;
@@ -1781,6 +1849,10 @@ static int rzg3s_pcie_resume_noirq(struct device *dev) if (ret) return ret; + ret = rzg3s_sysc_config_func(sysc, RZG3S_SYSC_FUNC_ID_MODE, 1); + if (ret) + return ret; + ret = rzg3s_pcie_power_resets_deassert(host); if (ret) goto assert_rst_rsm_b;
@@ -1841,11 +1913,37 @@ static const struct rzg3s_pcie_soc_data rzg3s_soc_data = { }, }; +static const char * const rzg3e_soc_power_resets[] = { "aresetn" }; + +static const struct rzg3s_pcie_soc_data rzg3e_soc_data = { + .power_resets = rzg3e_soc_power_resets, + .num_power_resets = ARRAY_SIZE(rzg3e_soc_power_resets), + .config_pre_init = rzg3e_pcie_config_pre_init, + .config_post_init = rzg3e_config_post_init, + .config_deinit = rzg3e_config_deinit, + .sysc_info = { + .functions = { + [RZG3S_SYSC_FUNC_ID_L1_ALLOW] = { + .offset = 0x1020, + .mask = BIT(0), + }, + [RZG3S_SYSC_FUNC_ID_MODE] = { + .offset = 0x1024, + .mask = BIT(0), + }, + }, + }, +}; + static const struct of_device_id rzg3s_pcie_of_match[] = { { .compatible = "renesas,r9a08g045-pcie", .data = &rzg3s_soc_data, }, + { + .compatible = "renesas,r9a09g047-pcie", + .data = &rzg3e_soc_data, + }, {} };
--
2.25.1