Thread (10 messages) 10 messages, 3 authors, 2026-02-06

Re: [RFC] pinctrl: pinconf-generic: move ..dt_node_to_map_pinmux() to amlogic-am4 driver

From: Andy Shevchenko <hidden>
Date: 2026-02-04 08:05:38
Also in: linux-amlogic, linux-gpio, lkml

On Wed, Feb 04, 2026 at 12:34:36AM +0100, Linus Walleij wrote:
On Tue, Feb 3, 2026 at 5:17 PM Conor Dooley [off-list ref] wrote:
quoted
pinconf_generic_dt_node_to_map_pinmux() is not actually a generic
function, and really belongs in the amlogic-am4 driver. There are three
reasons why.
(...)
quoted
The other dt_node_to_map implementations accept a being called for
either a node containing pin configuration properties or a node
containing child nodes that each contain the configuration properties.
IOW, they support the following two devicetree configurations:

| cfg {
|       label: group {
|               pinmux = <asjhdasjhlajskd>;
|               config-item1;
|       };
| };

| label: cfg {
|       group1 {
|               pinmux = <dsjhlfka>;
|               config-item2;
|       };
|       group2 {
|               pinmux = <lsdjhaf>;
|               config-item1;
|       };
| };

pinconf_generic_dt_node_to_map_pinmux() only supports the latter.
This alone is a good reason to apply the patch.

I have a strong urge to apply this already for v7.0 despite its RFC state.

Anyone against?
Quite the opposite! I fully support unloading pin control core from OF-centric
code. Note, please, remove extra '.' (dot) in the Subject.o
Acked-by: Andy Shevchenko <redacted>

-- 
With Best Regards,
Andy Shevchenko


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help