Thread (10 messages) 10 messages, 3 authors, 2026-02-06

Re: [RFC] pinctrl: pinconf-generic: move ..dt_node_to_map_pinmux() to amlogic-am4 driver

From: Linus Walleij <linusw@kernel.org>
Date: 2026-02-03 23:34:47
Also in: linux-amlogic, linux-gpio, lkml

On Tue, Feb 3, 2026 at 5:17 PM Conor Dooley [off-list ref] wrote:
From: Conor Dooley <conor.dooley@microchip.com>

pinconf_generic_dt_node_to_map_pinmux() is not actually a generic
function, and really belongs in the amlogic-am4 driver. There are three
reasons why.
(...)
The other dt_node_to_map implementations accept a being called for
either a node containing pin configuration properties or a node
containing child nodes that each contain the configuration properties.
IOW, they support the following two devicetree configurations:

| cfg {
|       label: group {
|               pinmux = <asjhdasjhlajskd>;
|               config-item1;
|       };
| };

| label: cfg {
|       group1 {
|               pinmux = <dsjhlfka>;
|               config-item2;
|       };
|       group2 {
|               pinmux = <lsdjhaf>;
|               config-item1;
|       };
| };

pinconf_generic_dt_node_to_map_pinmux() only supports the latter.
This alone is a good reason to apply the patch.

I have a strong urge to apply this already for v7.0 despite its RFC state.

Anyone against?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help