Re: [PATCH v1 20/50] ARM: dts: exynos: change and rename FSYS OPP table in Exynos5420
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2019-07-17 08:39:52
Also in:
linux-clk, linux-devicetree, linux-samsung-soc, lkml
On Mon, 15 Jul 2019 at 14:44, Lukasz Luba [off-list ref] wrote:
The FSYS and FSYS2 buses have similar characteristics and both have max frequency 240MHz. The old OPP table bus_fsys_apb_opp_table should be used only to FSYS APB bus because APB max frequency is 200MHz. The new OPPs for FSYS should increase its performance and related devices.
I do not understand the explanation. You say that there are two buses - FSYS and FSYS2 - and old OPP table should be used for FSYS APB but you remove the old one (by renaming). Or which one is the 'old one' here? The reason is speed... wait, what? Usually DTS should describe the HW so I imagine that proper opp table should be used for proper bus. It surprised me that we switch a bus to different OPP table just because of speed concerns. It should be correctness concern. Please clarify and reword all this. I am also not sure how this relates with previous patch - whether you are fixing independent issues. Maybe because I do not see the issue fixed... change the commit title and adjust the messages to focus WHY you are doing it. For small fixes WHAT you are doing is rather obvious so commit msg (and title) should not focus on it. Best regards, Krzysztof
quoted hunk ↗ jump to hunk
Signed-off-by: Lukasz Luba <redacted> --- arch/arm/boot/dts/exynos5420.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 941c58bdd809..c7fc4b829b2a 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi@@ -995,7 +995,7 @@ compatible = "samsung,exynos-bus"; clocks = <&clock CLK_DOUT_ACLK200_FSYS>; clock-names = "bus"; - operating-points-v2 = <&bus_fsys_apb_opp_table>; + operating-points-v2 = <&bus_fsys_opp_table>; status = "disabled"; };@@ -1003,7 +1003,7 @@ compatible = "samsung,exynos-bus"; clocks = <&clock CLK_DOUT_ACLK200_FSYS2>; clock-names = "bus"; - operating-points-v2 = <&bus_fsys2_opp_table>; + operating-points-v2 = <&bus_fsys_opp_table>; status = "disabled"; };@@ -1157,7 +1157,7 @@ }; }; - bus_fsys2_opp_table: opp_table5 { + bus_fsys_opp_table: opp_table5 { compatible = "operating-points-v2"; opp00 { --2.17.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel