Thread (28 messages) 28 messages, 4 authors, 2015-07-03

[PATCH-V2 11/12] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

flat view
STALE4127d SUPERSEDED

From: Vaibhav Hiremath <hidden>
Date: 2015-07-03 18:17:10
Also in: linux-i2c

Revision v2 of 6 in this series.

Revisions (6)
  1. v1 [diff vs current]
  2. v2
  3. v2
  4. v2 current
  5. v3 [diff vs current]
  6. v4 [diff vs current]

On Friday 03 July 2015 08:58 PM, Robert Jarzmik wrote:
Vaibhav Hiremath [off-list ref] writes:
quoted
+	i2c->clk = devm_clk_get(&dev->dev, NULL);
+	if (IS_ERR(i2c->clk)) {
+		dev_err(&dev->dev, "failed to get the clk\n");
+		dev_err(&dev->dev, "failed to get the clk: %ld\n", PTR_ERR(i2c->clk));
quoted
+		return PTR_ERR(i2c->clk);
+	}
Why is this block moving up ? I can't find the reason in the commit message or
in the code.
Because of obvious reason :)

The clk_rate is being used in i2c_pxa_probe_dt() function.

Although I did not mention in commit description as I felt it is
evident from the patch.
Probably should have been more descriptive here, sorry for that.
I will take care of it in next version.

Thanks,
Vaibhav
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help