Thread (28 messages) 28 messages, 4 authors, 2015-07-03

[PATCH-V2 03/12] i2c: pxa: Return I2C_RETRY when timeout in pio mode

flat view
STALE4126d SUPERSEDED

From: Shubhrajyoti Datta <hidden>
Date: 2015-06-16 05:31:44
Also in: linux-i2c

Revision v2 of 6 in this series.

Revisions (6)
  1. v1 [diff vs current]
  2. v2
  3. v2 current
  4. v2
  5. v3 [diff vs current]
  6. v4 [diff vs current]

Possibly related (same subject, not in this thread)

On Mon, Jun 15, 2015 at 9:19 PM, Vaibhav Hiremath
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Shouming Wang <redacted>

In case of timeout in pio mode of operation return I2C_RETRY.
This behavior will be same as interrupt mode of operation.

Signed-off-by: Shouming Wang <redacted>
[vaibhav.hiremath at linaro.org: Updated changelog]
Signed-off-by: Vaibhav Hiremath <redacted>
---
 drivers/i2c/busses/i2c-pxa.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 023e59f..632008f 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -745,8 +745,10 @@ static int i2c_pxa_do_pio_xfer(struct pxa_i2c *i2c,
        ret = i2c->msg_idx;

 out:
-       if (timeout == 0)
+       if (timeout == 0) {
                i2c_pxa_scream_blue_murder(i2c, "timeout");
+               ret = I2C_RETRY;
Can we use standard  return types.
+       }

        return ret;
 }
--
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help