Thread (28 messages) 28 messages, 4 authors, 2015-07-03

[PATCH-V2 04/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode

flat view
STALE4128d SUPERSEDED

From: Vaibhav Hiremath <hidden>
Date: 2015-07-03 18:13:18
Also in: linux-i2c

Revision v2 of 8 in this series.

Revisions (8)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v2
  5. v2
  6. v2 current
  7. v3 [diff vs current]
  8. v4 [diff vs current]

On Friday 03 July 2015 08:57 PM, Robert Jarzmik wrote:
Vaibhav Hiremath [off-list ref] writes:
quoted
In case of timeout during msg xfer assert reset to
i2c controller for both interrupt and PIO mode of operation.

Signed-off-by: Jett.Zhou <redacted>
[vaibhav.hiremath at linaro.org: Split & merge patches into logical changes
and update the Changelog]
Signed-off-by: Vaibhav Hiremath <redacted>
I already said it previously, I'm against an unconditional reset in a timeout
path. Make it a quirk or whatever, but in the current status, I'm against.

The previous behavior looks correct to me : upon timeout, retry, no need to
reset.
We still do return RETRY here, but also assert reset to I2C.

Anyway, lets revisit this again later. I will remove it in my next
version.

Thanks,
Vaibhav
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help