[PATCH-V2 07/12] i2c:pxa: Use devm_ variants in probe function
flat view
STALE4127d
SUPERSEDED: 1 (1M)
From: robert.jarzmik@free.fr (Robert Jarzmik)
Date: 2015-07-03 15:28:02
Also in:
linux-i2c
Revision v2 of 6 in this series; 1 review trailer.
Revisions (6)
- v1 [diff vs current]
- v2
- v2 current
- v2
- v3 [diff vs current]
- v4 [diff vs current]
Vaibhav Hiremath [off-list ref] writes:
quoted hunk ↗ jump to hunk
@@ -1201,16 +1201,17 @@ static int i2c_pxa_probe(struct platform_device *dev) strlcpy(i2c->adap.name, "pxa_i2c-i2c", sizeof(i2c->adap.name)); - i2c->clk = clk_get(&dev->dev, NULL); + i2c->clk = devm_clk_get(&dev->dev, NULL); if (IS_ERR(i2c->clk)) { - ret = PTR_ERR(i2c->clk); - goto eclk; + dev_err(&dev->dev, "failed to get the clk\n");
For consistency's sake, please use : dev_err(&dev->dev, "failed to get the clk: %ld\n", PTR_ERR(i2c->clk)); Once that is done, you can add my : Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> -- Robert