[PATCH-V2 07/12] i2c:pxa: Use devm_ variants in probe function

On Friday 03 July 2015 08:58 PM, Robert Jarzmik wrote:

Vaibhav Hiremath [off-list ref] writes:

quoted

@@ -1201,16 +1201,17 @@ static int i2c_pxa_probe(struct platform_device *dev)

  	strlcpy(i2c->adap.name, "pxa_i2c-i2c", sizeof(i2c->adap.name));

-	i2c->clk = clk_get(&dev->dev, NULL);
+	i2c->clk = devm_clk_get(&dev->dev, NULL);
  	if (IS_ERR(i2c->clk)) {
-		ret = PTR_ERR(i2c->clk);
-		goto eclk;
+		dev_err(&dev->dev, "failed to get the clk\n");

For consistency's sake, please use :
		dev_err(&dev->dev, "failed to get the clk: %ld\n", PTR_ERR(i2c->clk));

Will include it in next version.

Once that is done, you can add my :
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Thanks for your ack

Thanks,
Vaibhav