[PATCH] ata: Don't use NO_IRQ in pata_of_platform driver
From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2011-12-06 06:18:15
Also in:
linux-devicetree, linux-ide, linux-next, lkml
From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2011-12-06 06:18:15
Also in:
linux-devicetree, linux-ide, linux-next, lkml
On 18:45 Mon 05 Dec , Alan Cox wrote:
quoted
But as you illustrated, there is a large number of drivers that already assume no IRQ is < 0, even if they don't use any IRQ #0 themselves. That is a much bigger problem to fix.And a much larger number assuming the reverse is true which are hiding potential bugs on ARM. Looking at the serial stuff the best checks appear to be looking at "irq", "-1" and NO_IRQ. For migration stuff that's doing broken things like if (irq < 0) can be changed to if (irq <= 0) and that can be done before NO_IRQ itself is nailed on ARM and PA-RISC.
can we sinply introduce a macro irq_is_valid and make it chip dependant as gpio_is_valid and then move away from irq 0 valid so we do not need to brake anthing first and then easly convert them Best Regards, J.