[PATCH] ata: Don't use NO_IRQ in pata_of_platform driver
From: Alan Cox <hidden>
Date: 2011-12-05 20:52:59
Also in:
linux-devicetree, linux-ide, linux-next, lkml
On Mon, 05 Dec 2011 14:47:29 -0600 Rob Herring [off-list ref] wrote:
On 12/05/2011 02:21 PM, Anton Vorontsov wrote:quoted
On Mon, Dec 05, 2011 at 01:16:39PM -0600, Rob Herring wrote: [...]quoted
At least for DT enabled platforms, we could force "no irq" to be 0 in the DT irq code. Searching the dts files, I found 2 occurrences of IRQ0.Please note that there are HW IRQ numbers and "Virtual" IRQ numbers. dev->irq and thus the thing that we pass into request_irq() is a virtual IRQ thing, a "cookie". While in device tree you see real HW IRQ numbers. Legal VIRQ is always > 0, while HW IRQ could be >= 0.If this was all true, then there would be no discussion.
Or more to the point. If the ARM people concerned had listened in 2005, 2006 or 2008 there would be no discussion.
This is what we are working towards, but irq_chips all over the arm tree do not support any translation or have base fixed at compile time. Only a few have been converted. And some ARM platforms may never get converted to DT.
You've had six years. Let them break, it'll motivate any users to fix them. Alan