[PATCH] ata: Don't use NO_IRQ in pata_of_platform driver
From: Nicolas Pitre <hidden>
Date: 2011-12-05 17:40:25
Also in:
linux-devicetree, linux-ide, linux-next, lkml
On Mon, 5 Dec 2011, Dave Martin wrote:
On Sat, Dec 03, 2011 at 10:12:53AM +1100, Benjamin Herrenschmidt wrote:quoted
On Fri, 2011-12-02 at 11:28 -0800, Linus Torvalds wrote:quoted
Don't *change* NO_IRQ to zero (that whole #define is broken - leave it around as a marker of brokenness), just start removing it from all the ARM drivers that use the OF infrastructure. Which is presumably not all that many yet. So whenever you find breakage, the fix now is to just remove NO_IRQ tests, and replace them with "!irq".Russell, do you know whether it would make sense to set a timeline for removing NO_IRQ from ARM platforms and migrating to 0 for the no-interrupt case? I'm assuming that this mainly involves migrating existing hard-wired code that deals with interrupt numbers to use irq domains.
How many drivers do use IRQ #0 to start with? We might discover that in practice there is only a very few cases where this is an issue if 0 would mean no IRQ. Nicolas