Re: [PATCH v7 01/15] sched/core: uclamp: Add CPU's clamp buckets refcounting
From: Patrick Bellasi <hidden>
Date: 2019-03-14 15:08:01
Also in:
linux-pm, lkml
From: Patrick Bellasi <hidden>
Date: 2019-03-14 15:08:01
Also in:
linux-pm, lkml
On 14-Mar 14:32, Peter Zijlstra wrote:
On Thu, Mar 14, 2019 at 12:13:15PM +0000, Patrick Bellasi wrote:quoted
quoted
I'd be most impressed if they pull this off. Check the generated code and see I suppose :-)On x86 the code generated looks exactly the same: https://godbolt.org/z/PjmA7kArgh, they do mult by inverse to avoid the division, and can do this because its a constant. And then yes, your arm version looks worse.
your "arm version" is worst then x86, or "your version" is worse? IOW, should I keep the code as the original? Do you prefer your version? Or... we don't really care...
It does what I expected with -Os, but as Rutland said the other day, that stands for Optimize for Sadness.
Yes, I guess we cannot optimize for all flags... however, just let me know what you prefer and I'll put that version in ;) -- #include <best/regards.h> Patrick Bellasi