Thread (84 messages) 84 messages, 6 authors, 2019-03-19

Re: [PATCH v7 01/15] sched/core: uclamp: Add CPU's clamp buckets refcounting

From: Patrick Bellasi <hidden>
Date: 2019-03-13 15:28:40
Also in: linux-pm, lkml

On 13-Mar 15:06, Peter Zijlstra wrote:
On Fri, Feb 08, 2019 at 10:05:40AM +0000, Patrick Bellasi wrote:
quoted
+static void __init init_uclamp(void)
+{
+	unsigned int clamp_id;
+	int cpu;
+
+	for_each_possible_cpu(cpu)
+		memset(&cpu_rq(cpu)->uclamp, 0, sizeof(struct uclamp_rq));
+
Is that really needed? Doesn't rq come from .bss ?
Will check better... I've just assumed not since in sched_init() we
already have tons of rq's related zero initializations.

-- 
#include <best/regards.h>

Patrick Bellasi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help