Thread (218 messages) flat view 218 messages, 9 authors, 2016-11-06

Re: [PATCH 22/22] sequencer: refactor write_message()

From: Johannes Schindelin <hidden>
Date: 2016-09-09 14:40:55

Hi Kuba,

On Fri, 2 Sep 2016, Jakub Narębski wrote:
W dniu 01.09.2016 o 16:20, Johannes Schindelin pisze:
quoted
On Thu, 1 Sep 2016, Jakub Narębski wrote: 
quoted
W dniu 29.08.2016 o 10:06, Johannes Schindelin pisze:
quoted
quoted
quoted
 	if (commit_lock_file(&msg_file) < 0)
 		return error(_("Error wrapping up %s."), filename);
Another "while at it"... though the one that can be safely postponed
(well, the make message easier to understand part, not the quote
filename part):

  		return error(_("Error wrapping up writing to '%s'."), filename);
As I inherited this message, I'll keep it.
Well, please then add quotes while at it, at least, for consistency

  		return error(_("Error wrapping up '%s'."), filename);
I may do that as a final patch, once all the other concerns are addressed.
I really do not want to change the error message during the conversion.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help