Thread (218 messages) flat view 218 messages, 9 authors, 2016-11-06

Re: [PATCH 04/22] sequencer: future-proof remove_sequencer_state()

From: Johannes Schindelin <hidden>
Date: 2016-08-29 11:20:10

Hi Dennis,

On Mon, 29 Aug 2016, Johannes Schindelin wrote:
On Mon, 29 Aug 2016, Dennis Kaarsemaker wrote:
quoted
On ma, 2016-08-29 at 10:04 +0200, Johannes Schindelin wrote:
quoted
+       if (read_and_refresh_cache(opts))
+               return -1;
+
This doesn't seem to be related to the get_dir changes?
Good eyes.

Let me investigate why I have it here...
Unfortunately my reflogs got corrupted by the git-worktree
implementations, so I cannot back that far.

Looking at the code, and after running the tests, I am convinced that it
is a leftover of some misguided attempt to implement "git rebase -i
--abort" in sequencer_rollback().

I removed this hunk from the patch.

Again, Thank you so much for your review!
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help