Thread (218 messages) 218 messages, 9 authors, 2016-11-06

Re: [PATCH 12/22] sequencer: refactor the code to obtain a short commit name

flat view

From: Johannes Schindelin <hidden>
Date: 2016-08-29 11:04:58

Hi Dennis,

On Mon, 29 Aug 2016, Dennis Kaarsemaker wrote:
On ma, 2016-08-29 at 10:05 +0200, Johannes Schindelin wrote:

<snip actual commit>

I fail to see the point of this patch, would you mind enlightening me?
Two reasons:

1) by refactoring it into a function, the code is more DRY (with all the
advantages that come with it, such as: only a single point to change if
changing the behavior)

2) it is easier to reuse the code in upcoming patches (that would be in
the next patch series)

Will amend the commit message.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help