Re: [PATCH 07/21] Copy the remaining differences from verify_tag() to parse_tag_buffer_internal()

Hi,

On Sat, 9 Jun 2007, Johan Herland wrote:

I'm probably splitting this up into too small pieces, since I keep 
getting comments that fail to see the overall picture of what I'm trying 
to do, [...]

Maybe I said that your patch was too large. But then, I said something 
much more important: hard-to-review.

These small patches, split in a manner making it even more difficult to 
understand what you want to accomplish, do not help.

Yes, you should make small patches. Even small patch series. But in such a 
fashion that a reviewer can see that it is a good patch[*1*]. Just lean 
back, look at your patches, and ask yourself how you would have reacted if 
you had reviewed them.

Ciao,
Dscho

*1* A good patch follows the immortal words of Saint Exupery: A designer 
knows he has achieved perfection not when there is nothing left to add, 
but when there is nothing left to take away.