Thread (61 messages) flat view 61 messages, 4 authors, 2016-06-15

Re: [PATCH] Fix failed tag parsing when tag object has no body/message (and thus ends with a single '\n')

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:14

Possibly related (same subject, not in this thread)

Johan Herland [off-list ref] writes:
Thanks to Johannes Schindelin [off-list ref] for
discovering this.

Also add a testcase for this condition.

Signed-off-by: Johan Herland <redacted>
While this certainly is an improvement, I suspect that your
parse_tag() does a little too much.  In a format such as "tag"
object that does header + blank + body, it is customary to allow
header fields that your version does not understand (assuming
that such extention will go after the known fields is fine).

Which means that you should not be even saying "Ok, I've checked all
headers I know about---there should be a double LF to terminate it",
as you do not know if headers have ended.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help