Re: [PATCH 10/21] Free mktag's buffer before dying

On 6/9/07, Johan Herland [off-list ref] wrote:

+       if (parse_and_verify_tag_buffer(0, buffer, size, 1)) {
+               free(buffer);
+               die("invalid tag data file");

This, and the similar one below are useless. You're destroying the
process, what do you free that buffer for? Either handle the error
case or do not needlessly complicate your change, which really
also absolutely unneeded.