Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option
From: Juraj Linkeš <hidden>
Date: 2021-01-20 08:41:50
-----Original Message----- From: Honnappa Nagarahalli <redacted> Sent: Wednesday, January 20, 2021 3:20 AM To: thomas@monjalon.net; Bruce Richardson <redacted>; Juraj Linkeš [off-list ref] Cc: Ruifeng Wang <redacted>; Phil Yang [off-list ref]; vcchunga@amazon.com; Dharmik Thakkar [off-list ref]; jerinjacobk@gmail.com; hemant.agrawal@nxp.com; Ajit Khaparde (ajit.khaparde@broadcom.com) [off-list ref]; ferruh.yigit@intel.com; aboyer@pensando.io; dev@dpdk.org; nd [off-list ref]; Honnappa Nagarahalli [off-list ref]; nd [off-list ref] Subject: RE: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option <snip>quoted
20/01/2021 02:04, Honnappa Nagarahalli:quoted
quoted
On Tue, Jan 19, 2021 at 04:52:19PM +0100, Thomas Monjalon wrote:quoted
19/01/2021 15:56, Juraj Linkeš:quoted
From: Thomas Monjalon <redacted>quoted
15/01/2021 14:26, Juraj Linkeš:quoted
--- a/meson_options.txt +++ b/meson_options.txt +option('arm_soc', type: 'string', value: '', + description: 'Specify if you want to build for a +particular +aarch64 Arm SoC when building on an aarch64 machine.')Why the option is named "arm_soc" and not just "soc"? The same option could be used by other archs, isn't it?Agree that a more generic name would be better. I'll change it to "soc" if there are no other suggestions.Another name could be "machine". Should it be the same mechanism as compiling for a specific x86 CPU from an x86 machine?I'd rather not re-use the term "machine", for a new use, better to use a new term IMHO.+1, agree. 'soc' sounds good to me.Another possible word is "platform", as in http://doc.dpdk.org/guides/platform/index.htmlI am fine with 'platform' too.
'platform' is likely the best and actually works nicely with http://patches.dpdk.org/patch/85956/. Taken together, 'platform' could be either 'native', 'generic' or an soc, which is, I believe, exactly what we want.