Re: [dpdk-dev] [PATCH v13 10/12] build: disable libnuma in cross builds
From: Andrew Boyer <hidden>
Date: 2021-01-11 20:22:56
quoted hunk ↗ jump to hunk
On Nov 20, 2020, at 7:08 AM, Juraj Linkeš [off-list ref] wrote: Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disable NUMA in Arm cross files. Signed-off-by: Juraj Linkeš <redacted> Reviewed-by: Honnappa Nagarahalli <redacted> --- config/arm/arm64_armada_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1 + config/arm/arm64_dpaa_linux_gcc | 1 + config/arm/arm64_graviton2_linux_gcc | 1 + config/arm/arm64_n1sdp_linux_gcc | 1 + config/arm/arm64_octeontx2_linux_gcc | 1 + config/arm/arm64_stingray_linux_gcc | 1 + config/arm/meson.build | 2 -- config/meson.build | 19 +++++++++++++------ .../linux_gsg/cross_build_dpdk_for_arm64.rst | 4 ++++ 10 files changed, 24 insertions(+), 8 deletions(-) ...diff --git a/config/meson.build b/config/meson.build index 2bff6137f..9583be4ab 100644 --- a/config/meson.build +++ b/config/meson.build@@ -142,12 +142,19 @@ endif# check for libraries used in multiple places in DPDK has_libnuma = 0 -numa_dep = cc.find_library('numa', required: false) -if numa_dep.found() and cc.has_header('numaif.h') - dpdk_conf.set10('RTE_HAS_LIBNUMA', true) - has_libnuma = 1 - add_project_link_arguments('-lnuma', language: 'c') - dpdk_extra_ldflags += '-lnuma' +find_libnuma = true +if meson.is_cross_build() and not meson.get_cross_property('numa', true) + # don't look for libnuma if explicitly disabled in cross build + check_libnuma = false +endif
Looks like ‘check_libnuma’ should be ‘find_libnuma’. There are no other references to ‘check_libnuma’. -Andrew
+if find_libnuma
+ numa_dep = cc.find_library('numa', required: false)
+ if numa_dep.found() and cc.has_header('numaif.h')
+ dpdk_conf.set10('RTE_HAS_LIBNUMA', true)
+ has_libnuma = 1
+ add_project_link_arguments('-lnuma', language: 'c')
+ dpdk_extra_ldflags += '-lnuma'
+ endif
endif
...