On Jan 11, 2021, at 5:01 AM, Bruce Richardson [off-list ref] wrote:

On Mon, Jan 11, 2021 at 10:38:09AM +0100, Thomas Monjalon wrote:

quoted

08/01/2021 21:20, Honnappa Nagarahalli:

quoted

quoted

On Mon, Jan 04, 2021 at 05:46:20PM -0500, Andrew Boyer wrote:

quoted

1)  Bruce - when the “-Ddefault_library=both” flag is passed in, the build

fails with this error. It’s been broken for a long time; maybe this option isn’t
supported and should be blocked earlier?

quoted

	../../dpdk/app/meson.build:48:3: ERROR: Tried to get unknown

variable "both_rte_ethdev".

quoted

Revisiting this point, since there are a number of possible approaches we can
take here, and I'd like feedback on them before we do anything. Of these
approaches, 2 are simple, and 1 is more complicated.

1. We can just detect this as an invalid/unsupported setting and error out
earlier with a suitable errors message 2. Since we already support in all cases

I would prefer option 1 here (detect and error out). IMO, the option "both" does not seem to solve a compelling problem. I would prefer to avoid the additional code and complications. Mostly, everyone would do the development with either 'static' or 'shared' and test the other at the end when the development is completed.

+1 for not supporting linking with both.

Ok, thanks for the clear consensus. Will do patch to check and error out
appropriately.

/Bruce

It would be great if the error message for “both” pointed out that both sets of libraries are built in the “shared” case.
e.g.
‘Error: ‘both’ unsupported. ‘shared’ will build both static and shared libraries and dynamically-linked binaries. ‘static’ will build only static libraries and statically-linked binaries.’

-Andrew